feat: enable audio playback for dashboard route clips#616
Closed
Mahdi451 wants to merge 5 commits intocommaai:masterfrom
Closed
feat: enable audio playback for dashboard route clips#616Mahdi451 wants to merge 5 commits intocommaai:masterfrom
Mahdi451 wants to merge 5 commits intocommaai:masterfrom
Conversation
Changes:
Total lines: 4891 (+153) |
deployed preview: https://616.connect-d5y.pages.devWelcome to connect! Make sure to:
Mobile
Desktop
|
Author
|
The failing test check does not appear to be caused by this audio PR. Evidence:
Locally:
This looks like a separate flaky or externally dependent geocoding test issue rather than a regression from the audio change. |
Author
|
Following up on the earlier unrelated CI failure mentioned here: that issue was addressed separately in #617. That follow-up PR stabilizes the geocode tests and also fixes the GitHub Actions |
Author
Author
|
Closing this in favor of the fork-owned integration PR: Mahdi451#1 . The combined branch includes the route audio work plus the fork preview changes that will be validated in that preview. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.








Summary
Problem
Dashboard route clips in new-connect always played muted because the player hard-coded the HTML5 muted attribute and provided no way for the user to reverse it.
Fix
Testing
Closes #615